-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pvc): support kube_persistentvolumeclaim_deletion_timestamp #2074
feat(pvc): support kube_persistentvolumeclaim_deletion_timestamp #2074
Conversation
Welcome @maxime1907! |
b2a2550
to
636d302
Compare
636d302
to
b3f69e0
Compare
/triage accepted |
Signed-off-by: Maxime Leroy <[email protected]>
b3f69e0
to
c0eb61a
Compare
any update on this ? @mrueg @dgrisonnet |
/lgtm Thanks a lot for your contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxime1907, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds a simple metric
kube_persistentvolumeclaim_deletion_timestamp
so that we can detect PVCs in "Terminating" stateHow does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
increases
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1437