-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go version to 1.20.4 #2056
Conversation
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I've run the Twistlock tool against this and the report shows no vulnerabilities. |
I'm fine with the go 1.20.3 bump, I would like to see go-restful merged in kubernetes/kubernetes#115067 (in particular because of kubernetes/kubernetes#115067 (comment) ) before we include this here. |
@RamakrishnanArun It would be better to get this merged and a new release out. |
@liam-verta Thanks for your input. I think I misunderstood @mrueg 's comment. I understood it as a required change but only merged after the linked change in kubernetes/kubernetes#115067 merged first. So the reason for adding the change in both was that I got security vulnerabilities in both the go version and the version of go-restful that I am indirectly using with this project. That's why I wanted to add both updates. Should I split them into 2 different PRs? One for the Go version and then one for the Go-Restful version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For go-restful, I would suggest to reach out on kubernetes/kubernetes#115067
I doubt this is actually exploitable here though.
We use https://go.dev/security/vuln/ govulncheck here, which checks the affected codepaths.
Most of the other scanners use a noisy approach of simply checking go.mod files, which is unreliable.
Thank you @liam-verta @mrueg for your review and inputs! |
One last request, since this change has become a single line now. Can you rebase everything into a single commit? |
83057d7
to
81c1b3c
Compare
81c1b3c
to
847d6c8
Compare
@mrueg done! Single commit now. |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrueg, RamakrishnanArun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When do you think the next release would be done? |
@mrueg |
What this PR does / why we need it:
This PR upgrades the Go version to 1.20.3 and go-restful to 3.10.2 which resolves a number of security vulnerabilities.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality) Does not change
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2054