-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2047: Add LabelsFromPath functionality to Info metrics #2048
Conversation
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @murphd40! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, murphd40 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@murphd40 thank for contributing the fix and adding a unit test! :) |
What this PR does / why we need it:
This PR adds
LabelsFromPath
functionality to Info type metrics defined via acustomresourcestate.Resource
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
May increase under certain conditions (use of custom resource metrics of type info)
Which issue(s) this PR fixes
Fixes #2047
Testing
Before
After