-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add cli refrences to the docs around annotations and labels #1988
Conversation
Welcome @dfredell! |
/triage accepted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution 👍
/lgtm
/hold for @CatherineF-dev to take a look |
I presented/ reviewed this PR with my team and they caught some of my miss spellings, so I fixed, squashed, and pushed. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Hi @dfredell, sorry for letting your PR go stale. The docs improvements that you are proposing look good to me, but it would be great if you could propagate them to all the docs referencing label/annotation metrics. You can easily find those by running:
/remove-lifecycle stale |
…ly read in their text form. Used Markdown All in One in VSCode.
…e about labels and annotations to all markdown files.
@dgrisonnet These docs tables were incredibly hard to read in a text editor without extra white space and formatting. So I through them through https://open-vsx.org/extension/yzhang/markdown-all-in-one I have added the Description column to those MDs that didn't have them as requested. |
We could probably run https://github.com/marketplace/actions/markdownlint-cli2-action if we wanted to to improve our markdown formatting. |
I am fine with merging it then. @dfredell thank you for the contribution :) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfredell, dgrisonnet, fpetkovski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Add links to the command line flags for enabling labels and annotations in the docs
As the docs sit today we had struggled with figuring out why the
kube_pod_labels
metric were not gettinglabel_POD_LABEL
to populate. When we read docs/pod-metrics.md, we got the impression that all LABELS would be scraped and should appear in the metrics. The kubernetes pod itself had the labels on it.We then stumbled upon #1489 (comment) and lead us to figure out that not all LABELS were extracted by default. Adding
--metric-labels-allowlist
solved our issue. So this MR is intended to make it more obvious when reading docs/pod-metrics.md that all labels are not scraped by default.I only added the link to cli-arguments.md on docs that had the Description column.
How does this change affect the cardinality of KSM: does not change cardinality
Which issue(s) this PR fixes : fixes #1489