-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty string for "owner_*" dimensions in all metrics. #1923
Empty string for "owner_*" dimensions in all metrics. #1923
Conversation
… "owner_is_controller" dimensions. Returning empty string instead of "<none>" value for "owner_kind", "owner_name" and "owner_is_controller" dimensions when no metadata.ownerReferences exists in Kubernetes resoures.
…dimension. Returning empty string instead of special string "<none>" for "storageclass" dimensions of "kube_persistentvolumeclaim_info" metric.
@pawcykca: This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @pawcykca! |
/easycla |
Co-authored-by: Manuel Rüger <[email protected]>
I believe easycla is failing because it does not recognize the email in https://github.com/kubernetes/kube-state-metrics/pull/1923/commits/2c3ea01cb2c2ca3fa6ea9958d899f497ef14f5c0.patch ? |
/easycla |
/lgtm |
Thanks @pawcykca! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mrueg, pawcykca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Replace "" with empty string for "owner_kind", "owner_name" and "owner_is_controller" dimensions for all metrics.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not change cardinality.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1919