add ContainerResourceSourceType for hpa metrics #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
whitebear009
force-pushed
the
hpa
branch
2 times, most recently
from
9e50da3 to
633ba5c
Compare
k8s-ci-robot
added
size/L
|
/assign @mrueg |
dgrisonnet
reviewed
Sep 23, 2022
whitebear009
requested review from
dgrisonnet
and removed request for
mrueg and
fpetkovski
|
@whitebear009 my previous comments are still unresolved, could you have a look at them? |
|
@dgrisonnet My reply was not sent before, sorry. please check again |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, whitebear009 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
kubernetes hpa support ContainerResourceSourceType(https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#container-resource-metrics) since v1.20, but there is no metrics about it in the kube-state-metrics.
The PR add ContainerResourceSourceType for hpa metrics kube_horizontalpodautoscaler_spec_target_metric and kube_horizontalpodautoscaler_status_target_metric.
Then decrease cyclomatic complexity by reusing metricTarget objects, so as to pass golint-ci.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Increases cardinality. Add metrics for ContainerResourceSourceType hpa.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #