Add support for the ServiceAccount resource (Ref: #1717) #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Serializator
force-pushed
the
service-account-metrics-1717
branch
5 times, most recently
from
24d5185 to
80927f5
Compare
Serializator
force-pushed
the
service-account-metrics-1717
branch
from
80927f5 to
6a24f63
Compare
|
/approve |
k8s-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fpetkovski, mrueg, Serializator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It adds support for the ServiceAccount resource. It introduces the metrics below.
kube_serviceaccount_infokube_serviceaccount_createdkube_serviceaccount_deletedkube_serviceaccount_secretkube_serviceaccount_image_pull_secretkube_serviceaccount_annotationskube_serviceaccount_labelsHow does this change affect the cardinality of KSM:
It increases the cardinality.
Which issue(s) this PR fixes:
Fixes (partially) #1717