Add metric for pod tolerations (Ref: #1744) #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
fpetkovski
reviewed
Jun 29, 2022
|
/approve |
k8s-ci-robot
added
the
approved
|
This new metric looks good to me, I will approve the change once the tests are green. @Serializator you need to set expectedFamilies to 46 in the tests in order for the tests to pass since you added a new family. |
|
@dgrisonnet, good one. I will update this at the end of the day. |
Serializator
force-pushed
the
kube-pod-tolerations-metric-1744
branch
from
ca7a4f8 to
a0980c8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgrisonnet, mrueg, Serializator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a metric for pod tolerations.
How does this change affect the cardinality of KSM:
It increases the cardinality.
Which issue(s) this PR fixes:
Fixes #1744