internal/store: fix metrics slice length #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: In kubernetes#1723 a potential panic in the pod metrics gathering was fixed by working around a disconnect of `Spec.Containers` and `Status.ContainerStatuses`. The slice storing the resulting metrics however was still defined based on the length of the `Status.ContainerStatuses` list. Solution: Make the slice dynamic and append metrics to it. Signed-off-by: Jan Fajerski <[email protected]>
|
|
k8s-ci-robot
added
cncf-cla: no
k8s-ci-robot
added
cncf-cla: yes
|
Thanks. Instead of trying to guess the slice length, I think this is the more sane approach. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fpetkovski, jan--f The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
honpey
pushed a commit
to honpey/kube-state-metrics
that referenced
this pull request
May 17, 2022
In kubernetes#1731, the dynamic slice was introduced to fix potential panic under Spec.Containers scenario, however there may be same panic for Spec.InitContainers scenario. This patch fix it referring to kubernetes#1731
honpey
added a commit
to honpey/kube-state-metrics
that referenced
this pull request
May 17, 2022
In kubernetes#1731, the dynamic slice was introduced to fix potential panic under Spec.Containers scenario, however there may be same panic for Spec.InitContainers scenario. This patch fix it referring to kubernetes#1731 Signed-off-by: honpey <[email protected]>
honpey
added a commit
to honpey/kube-state-metrics
that referenced
this pull request
May 30, 2022
In kubernetes#1731, the dynamic slice was introduced to fix potential panic under Spec.Containers scenario, however there may be same panic for Spec.InitContainers scenario. This patch fix it referring to kubernetes#1731 Signed-off-by: honpey <[email protected]>
Merged
sherifabdlnaby
pushed a commit
to sherifabdlnaby/kube-state-metrics
that referenced
this pull request
Jul 9, 2022
In kubernetes#1731, the dynamic slice was introduced to fix potential panic under Spec.Containers scenario, however there may be same panic for Spec.InitContainers scenario. This patch fix it referring to kubernetes#1731 Signed-off-by: honpey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: In #1723 a
potential panic in the pod metrics gathering was fixed by working around
a disconnect of
Spec.ContainersandStatus.ContainerStatuses. Theslice storing the resulting metrics however was still defined based on
the length of the
Status.ContainerStatuseslist.Solution: Make the slice dynamic and append metrics to it.
Signed-off-by: Jan Fajerski [email protected]
What this PR does / why we need it:
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #