feat(hpa): status current metric

[tanguyfalconnet]

Signed-off-by: Tanguy Falconnet [email protected]

What this PR does / why we need it:

We want to be able to have current status of target metrics used by HPA.
We are currently not able to know if our HPA target metrics are healthy or in <unknown> state. Used in pair with prometheus-adapter for custom metric scaling, this is an important metric to check to monitor our clusters.

How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)

Increases, as it adds a new metric kube_horizontalpodautoscaler_status_current_target_metric, mostly the same as kube_horizontalpodautoscaler_spec_target_metric

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: tanguyfalconnet / name: Tanguy Falconnet (3eb7aa4, 6906e07, b26d663, 20084df, b09674c, 8e5d283)

[k8s-ci-robot]

Welcome @tanguyfalconnet!

It looks like this is your first PR to kubernetes/kube-state-metrics 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kube-state-metrics has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[fpetkovski]

This is looking good so far, just a few nits from my side

[fpetkovski]

Thanks for the contribution. Could you you also sign the CLA so that we can make the CI green?

You can squash all your commits and run

git commit --amend --no-edit --signoff

[tanguyfalconnet]

Thanks for the contribution. Could you you also sign the CLA so that we can make the CI green?

You can squash all your commits and run

git commit --amend --no-edit --signoff

CLA is being reviewed by my company. I'll sign it when everything is ready on our side. Next time it'll go faster ^^

[mrueg]

@tanguyfalconnet do you have an update from your company on the CLA?

[tanguyfalconnet]

@mrueg It's finally ok. It seems that similar code is already merged. I'll let you close it/merge it as you wish.

[mrueg]

Thanks for the update @tanguyfalconnet!
We're waiting on a response from the author of #1788 (comment) to make sure that it's clear where this code is coming from. So I'll keep this open so we can still use it to ensure correct authorship.

[mrueg]

/lgtm

/hold
for @fpetkovski @dgrisonnet to take a look.

[dgrisonnet]

Thank you for looking into this @tanguyfalconnet.

/lgtm
/approve
/unhold

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, mrueg, tanguyfalconnet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dgrisonnet,mrueg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment