[release-2.0] Update go to 1.16, update dependencies, remove vendor directory #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
the
cncf-cla: yes
mrueg
commented
Mar 18, 2021
| k8s.io/apimachinery v0.18.3 => k8s.io/apimachinery v0.18.3 | ||
| k8s.io/client-go v0.18.3 => k8s.io/client-go v0.20.0 | ||
| k8s.io/api v0.18.3 => k8s.io/api v0.20.4 | ||
| k8s.io/apimachinery v0.18.3 => k8s.io/apimachinery v0.20.4 |
There was a problem hiding this comment.
@lilic not sure if you wanted to keep apimachinery on 0.18.3 on purpose or this change is okay
There was a problem hiding this comment.
Most likely a mistake on my side, 0.20.4 sounds great!
Signed-off-by: Kemal Akkoyun <[email protected]> Signed-off-by: Manuel Rüger <[email protected]>
mrueg
changed the title
lilic
approved these changes
Mar 18, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, mrueg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mrueg
added a commit
to mrueg/kube-state-metrics
that referenced
this pull request
Mar 26, 2021
* [CHANGE] Rename --labels-metric-allow-list to --metric-labels-allowlist kubernetes#1424 * [CHANGE] Remove deprecated Kubernetes APIs kubernetes#1423 * [CHANGE] Remove vendor folder kubernetes#1419
Merged
mrueg
added a commit
to mrueg/kube-state-metrics
that referenced
this pull request
Mar 26, 2021
* [CHANGE] Rename --labels-metric-allow-list to --metric-labels-allowlist kubernetes#1424 * [CHANGE] Remove deprecated Kubernetes APIs kubernetes#1423 * [CHANGE] go.mod: Update Dependencies kubernetes#1419 * [CHANGE] Remove vendor folder kubernetes#1419 * [CHANGE] `k8s.gcr.io/kube-state-metrics/kube-state-metrics` becomes the authoritative registry Location on quay.io will not be updated anymore. Previously pushed images will be kept around to avoid breaking existing deployments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This changes the used go version in the build process to 1.16 and updates various dependencies.
It also removes the /vendor directory