fix labels-metric-allow-list documentation #1404
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
The parser defined in types.go does not expect quotes https://github.com/kubernetes/kube-state-metrics/blob/master/pkg/options/types.go#L136-L140 https://github.com/kubernetes/kube-state-metrics/blob/master/pkg/options/types_test.go#L168
Mikulas
force-pushed
the
docs-label-allowlist-fix
branch
from
18e119e to
ffa4c7b
Compare
|
/kind bug |
k8s-ci-robot
added
the
kind/documentation
|
/label release-2.0 |
|
@Mikulas: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thank you! lgtm 👍 /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, Mikulas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
The parser defined in types.go does not expect quotes
https://github.com/kubernetes/kube-state-metrics/blob/release-2.0/pkg/options/types.go#L136-L140
https://github.com/kubernetes/kube-state-metrics/blob/release-2.0/pkg/options/types_test.go#L168
This issue is unfortunate because ksm does parse the quoted syntax fine but the labels never match (eg label is
foobut ksm matches against"foo"). As such this is pretty important patch for the 2.0 release. Further improvements could be made but this documentation fix is the bare minimum.Targeting release-2.0 (or should this be based on master and backported afterwards?)