Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use github actions for CI checks #1199

Merged
merged 2 commits into from
Aug 11, 2020
Merged

use github actions for CI checks #1199

merged 2 commits into from
Aug 11, 2020

Conversation

tariq1890
Copy link
Contributor

@tariq1890 tariq1890 commented Aug 4, 2020 •
edited
Loading

This PR replaces TravisCI with GitHub Actions

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2020
@tariq1890 tariq1890 force-pushed the gh-action branch 10 times, most recently from 0cf3310 to dfa537b Compare August 4, 2020 01:47
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 4, 2020
@tariq1890 tariq1890 force-pushed the gh-action branch 2 times, most recently from dafabf6 to 676899b Compare August 4, 2020 04:19
@tariq1890
Copy link
Contributor Author

/assign @lilic

mrueg
mrueg reviewed Aug 4, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
lilic
lilic reviewed Aug 4, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR, couple of questions:

  • who can rerun the jobs now?
  • As per @mrueg comment, we need to build on all branches.
  • Seems like the jobs are not run in parallel is there any way to do this?

@tariq1890
Copy link
Contributor Author

tariq1890 commented Aug 7, 2020 •
edited
Loading

@lilic

  • I am not too sure about re-running Github Actions. I think that should be available to us from the GH interface. Not sure If that needs to be taken care of via the workflow YAML

  • Addressed. Created a trigger for tag pushes

  • I've parallelised it. You'll see a lot of duplication, unfortunately, GitHub Actions does not re-usable steps as of yet. Once they do, we can remove the code duplication

@tariq1890 tariq1890 force-pushed the gh-action branch 2 times, most recently from cf30bcb to 1e98570 Compare August 7, 2020 07:50
@tariq1890
Copy link
Contributor Author

tariq1890 commented Aug 7, 2020 •
edited
Loading

Looks like the GitHub Actions jobs (Benchmark and E2E) are faster than TravisCI by a minute. That's a win for us :)

@brancz
Copy link
Member

brancz commented Aug 7, 2020

Giving @lilic last call, but this lgtm! 🎉

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2020
@lilic
Copy link
Member

lilic commented Aug 10, 2020

You seem to have a conflict, but otherwise lgtm, thanks Tariq!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2020
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 10, 2020
lilic
lilic reviewed Aug 11, 2020
View reviewed changes
Copy link
Member

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, lilic, tariq1890

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [brancz,lilic,tariq1890]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brancz
Copy link
Member

brancz commented Aug 11, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 44818d1 into kubernetes:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilic lilic lilic left review comments

@mrueg mrueg mrueg left review comments

@andyxning andyxning Awaiting requested review from andyxning

@zouyee zouyee Awaiting requested review from zouyee

Assignees

@brancz brancz

@lilic lilic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tariq1890 @brancz @lilic @k8s-ci-robot @mrueg