Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container label missing in kube_pod_status_container_ready_time #2053

Closed
bharathvenkatrajan opened this issue Apr 24, 2023 · 12 comments
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@bharathvenkatrajan
Copy link

What would you like to be added: kube_pod_status_container_ready_time should have the container label and be able to filter on a container level

https://github.com/kubernetes/kube-state-metrics/blob/main/docs/pod-metrics.md

Why is this needed: The metric kube_pod_status_container_ready_time is supposed to show the ready time for each container

Describe the solution you'd like
Need to add the container label to the metric kube_pod_status_container_ready_time
Adding a container label here? - https://github.com/kubernetes/kube-state-metrics/blob/main/internal/store/pod.go#L1339-L1364

@bharathvenkatrajan bharathvenkatrajan added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 24, 2023
@dgrisonnet
Copy link
Member

/triage accepted
/assign @CatherineF-dev

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 29, 2023
@CatherineF-dev
Copy link
Contributor

CatherineF-dev commented Jun 29, 2023

The metric name should be kube_pod_container_ready_time.

You can add this new metric @bharathvenkatrajan with container label.

Example PR is #1932

@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jun 28, 2024
@dgrisonnet
Copy link
Member

cc @Henrywu573

@dgrisonnet
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 19, 2024
@Henrywu573
Copy link
Contributor

/assign

@Henrywu573
Copy link
Contributor

@bharathvenkatrajan Would the kube_pod_container_state_started metric documented at this link meet your requirements?

@bharathvenkatrajan
Copy link
Author

@Henrywu573 Yes, that’s perfect. Thank you!

@Henrywu573
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@Henrywu573: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@richabanker
Copy link
Contributor

/close
Thanks @Henrywu573 for seeing through this issue!

@k8s-ci-robot
Copy link
Contributor

@richabanker: Closing this issue.

In response to this:

/close
Thanks @Henrywu573 for seeing through this issue!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

7 participants