-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch go-json-experiment json to pass tests on go1.22 #503
Patch go-json-experiment json to pass tests on go1.22 #503
Conversation
make sure the passes on both the current minimum version of go for this repo (go 1.20) and on go 1.22 / 1.23 |
nit: avoid mentioning the other repo / commit sha in the commit message here or github may ping that commit with a comment every time this commit is picked / merged anywhere |
e9f4eff
to
1d27184
Compare
Removed the commit referencing another commit sha and expanded the testing to test for all go versions 1.20-1.23 |
1d27184
to
24eb939
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jefftree, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
Per comment #501 (comment) and #501 (comment).
Fixes #501
This is manual patch to include the test fix from go-json-experiment/json@c2a874a. We cannot directly fast forward to that commit because it would increase our minimum supported go version to 1.21.
Tested manually via
go test