Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apelisse as approver to pkg/validation #330

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

apelisse
Copy link
Member

@liggitt Jordan, how do you feel about that?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2022
@liggitt
Copy link
Member

liggitt commented Nov 23, 2022

+1 on adding to reviewers list

For approvers, there isn't a ton of action in this subtree to get signal on historical reviews. It looks like the PRs to this package you've been a reviewer/author on have been:

Since stuff under here is API-facing (both in the serialized fields and in the behavior of the CRD validators), I'd look for a track record of you raising and driving to resolution compatibility implications of changes in reviews or changes you author.

@apelisse apelisse force-pushed the add-apelisse-validation branch from 6718c0a to af74d46 Compare November 23, 2022 21:42
@apelisse
Copy link
Member Author

Updated

@liggitt
Copy link
Member

liggitt commented Nov 23, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 86e75dd into kubernetes:master Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants