-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change references of googleapis/gnostic -> google/gnostic #285
Conversation
OK Thanks, |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apelisse, Jefftree The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think this breaks dependencies like I'm not entirely sure, since this is a bit over my head in how Go resolves dependencies. But it seems that because the old version So what's happening is I'm getting an But the exact compilation error when updating deps now is:
I'm not exactly sure how to work around this or what the resolution is. |
I guess I worked around it by pinning my indirect dependency to a sha before this one, and it resolved it. I wasn't able to reproduce it on a new project either, so I'm not sure the perfect storm that leads to this being a problem. |
@mattrobenolt Yes, we are aware there will be a version mismatch with kubernetes/kubernetes (and subsequently the client-go applyconfigurations) until kubernetes/kubernetes#108644 is merged. |
it shouldn't, as long as you use the level of kube-openapi referenced by client-go. did you run |
kubernetes/kube-openapi#285 will break things if we are using inconsitent version of kube-openapi
* Use the same version as in the sdk kubernetes/kube-openapi#285 will break things if we are using inconsitent version of kube-openapi * use kube-openapi e816edb12b65 for apply-replacements
* Use the same version as in the sdk kubernetes/kube-openapi#285 will break things if we are using inconsitent version of kube-openapi * use kube-openapi e816edb12b65 for apply-replacements
kube-openapi pinned before the migration to google/gnostic kubernetes/kube-openapi#285 google/gnostic#397
kube-openapi pinned before the migration to google/gnostic kubernetes/kube-openapi#285 google/gnostic#397
kube-openapi pinned before the migration to google/gnostic kubernetes/kube-openapi#285 google/gnostic#397
See kubernetes/kubernetes#108644
k/k and k/kube-openapi need to change googleapis/gnostic -> google/gnostic at the same time to avoid type check failure.
Test failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/108644/pull-kubernetes-integration/1502033895208521728
Change references of googleapis/gnostic -> google/gnostic
Also upgrade gnostic from 0.5.5 to 0.6.6. No significant changes for openapi_v2 and openapi_v3,
since April 26, 2021 @ version v0.5.5
/assign @apelisse