Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Production recommendations document #9984

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Production recommendations document #9984

merged 1 commit into from
Sep 25, 2020

Conversation

olemarkus
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2020
joshbranham
joshbranham approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@joshbranham joshbranham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍 thank you

docs/getting_started/production.md Show resolved Hide resolved
@joshbranham
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 24, 2020
@joshbranham
Copy link
Contributor

Unsure about the netlify errors, but otherwise

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2020
@olemarkus
Copy link
Member Author

Not sure what that is about either. mkdocs build doesn't work, but import hack.mkdocs_macros works ... make live-docs also works just fine.

@hakman
Copy link
Member

hakman commented Sep 25, 2020

I think a rebase should fix the mkdocs issue now that #9988 was merged.

@olemarkus olemarkus force-pushed the docs-prod-recommendations branch from 1e93658 to 7a7f1d7 Compare September 25, 2020 05:21
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2020
@hakman
Copy link
Member

hakman commented Sep 25, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit c18be9a into kubernetes:master Sep 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@joshbranham joshbranham Awaiting requested review from joshbranham

Assignees

@hakman hakman

@joshbranham joshbranham

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@olemarkus @joshbranham @hakman @k8s-ci-robot