-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing permissions for cilium-operator #9979
Conversation
Welcome @codablock! |
Hi @codablock. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
These became required a few cilium versions ago.
b682657
to
1bd219f
Compare
/ok-to-test I think the current default cilium version doesn't use 1.8.3 yet, which is why this hasn't been added. But thanks for catching this anyway. |
@olemarkus I'm using kops v1.19.0-alpha.4 and from what I can see, it has deployed cilium 1.8.3 to my cluster. I assume #9871 is the reason. |
Then I missed that part. Thanks! |
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: codablock, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These became required a few cilium versions ago.
This basically fixes the same as reported in kubespray: kubernetes-sigs/kubespray#6681, which was fixed in kubernetes-sigs/kubespray#6683
I encountered exactly the same error with kops and cilium. A follow up error is that the cilium agents fail and keep restarting due to the cilium-operator not starting up and not issuing heart beats.
EDIT: I'm not sure I understand the folder structure in
upup/models/cloudup/resources/addons/networking.cilium.io
. I already figured out that I have to run a local build first to update bindata.go...but I don't understand which of the 3 templates needs the changes.