Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use root volume encryption flag for LaunchConfiguration with TF and CF #9872

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Sep 5, 2020

#9793 missed the config flags for LaunchConfiguration with Terraform and CloudFormation.
This will be useful in kops 1.18.1.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2020
@olemarkus
Copy link
Member

/test pull-kops-e2e-kubernetes-aws

@hakman
Copy link
Member Author

hakman commented Sep 8, 2020

Thanks @olemarkus :)

@k8s-ci-robot k8s-ci-robot merged commit 3527d32 into kubernetes:master Sep 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Sep 8, 2020
@hakman hakman deleted the root-vol-encrypt-lc branch September 8, 2020 11:31
@hakman hakman restored the root-vol-encrypt-lc branch September 8, 2020 11:31
@hakman hakman deleted the root-vol-encrypt-lc branch September 8, 2020 11:31
k8s-ci-robot added a commit that referenced this pull request Sep 8, 2020
…9872-upstream-release-1.18

Automated cherry pick of #9793: Add flag for root volume encryption #9872: Use root volume encryption flag for LaunchConfiguration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants