Only add OS variables if they are needed #9778
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
pkg/model/bootstrapscript.go
Outdated
| @@ -511,3 +514,27 @@ func (b *BootstrapScript) createProxyEnv(ps *kops.EgressProxySpec) string { | |||
| } | |||
| return buffer.String() | |||
| } | |||
|
|
|||
| func usesOpenStack(cluster *kops.Cluster) bool { | |||
| if kops.CloudProviderID(cluster.Spec.CloudProvider) == kops.CloudProviderOpenstack { | |||
There was a problem hiding this comment.
@olemarkus Why isn't this enough to decide that the cloud provider is OpenStack?
There was a problem hiding this comment.
Technically you could run on AWS, but use swift as configbase. No one is probably doing this though.
The use case is common though, if you openstack as provider, using S3 as configbase is common.
There was a problem hiding this comment.
You are using this function to check if the cluster is OS.
Why is it not enough to check cluster.Spec.CloudProvider?
olemarkus
force-pushed
the
openstack-fix-noisy-env-vars
branch
from
b467424 to
94833fa
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Fixes #9775