Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for containerd v1.4.0 #9777

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Add support for containerd v1.4.0 #9777

merged 1 commit into from
Aug 18, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 18, 2020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2020
@johngmyers
Copy link
Member

Typo: "contained"

@hakman
Copy link
Member Author

hakman commented Aug 18, 2020

Typo: "contained"

Hehe. Thanks. Fixed.

@hakman hakman changed the title Add support for contained v1.4.0 Add support for containerd v1.4.0 Aug 18, 2020
@hakman
Copy link
Member Author

hakman commented Aug 18, 2020

/retest

@hakman
Copy link
Member Author

hakman commented Aug 18, 2020

/test pull-kops-e2e-k8s-containerd

1 similar comment
@hakman
Copy link
Member Author

hakman commented Aug 18, 2020

/test pull-kops-e2e-k8s-containerd

@hakman
Copy link
Member Author

hakman commented Aug 18, 2020 •
edited
Loading

New pull-kops-e2e-k8s-containerd test passed 3 times in a row. I think this is good to go.
https://prow.k8s.io/pr-history/?org=kubernetes&repo=kops&pr=9777

@rifelpet
Copy link
Member

Is k/k 1.19 defaulting to containerd 1.4.0 ?

@hakman
Copy link
Member Author

hakman commented Aug 18, 2020

k/k is testing against containerd master. There is no guideline yet for release versions and containerd.

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2020
@hakman
Copy link
Member Author

hakman commented Aug 18, 2020

/test pull-kops-e2e-k8s-containerd

@k8s-ci-robot k8s-ci-robot merged commit f1a0e03 into kubernetes:master Aug 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 18, 2020
@hakman hakman deleted the containerd-1.4.0 branch August 19, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @k8s-ci-robot @johngmyers @rifelpet