-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use /etc/os-release to identify the distribution #9766
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
OK this is a good simplification. Pondering whether we should fallback to the existing logic for a period... how did you get the example os-release files that you use in the tests? |
@justinsb I got the files from starting various VMs for the respective distros and copying the |
a37ede4
to
5e15bd3
Compare
If a fallback is added, will be very hard to catch any corner cases. |
/lgtm |
All supported distributions have the
/etc/os-release
file describing the distro info:http://0pointer.de/blog/projects/os-release