Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows job to GH workflows #9721

Merged
merged 6 commits into from
Aug 11, 2020
Merged

Add windows job to GH workflows #9721

merged 6 commits into from
Aug 11, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Aug 10, 2020

The kops binary for Windows is not tested anywhere.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2020
@hakman hakman removed the request for review from zetaab August 10, 2020 16:21
@hakman hakman changed the title Add windows job to GH workflows WIP Add windows job to GH workflows Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2020
@hakman hakman removed the request for review from mikesplain August 10, 2020 16:23
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Aug 10, 2020
@hakman hakman force-pushed the ghw-win-2019 branch 5 times, most recently from 9e29796 to b156d2f Compare August 11, 2020 05:21
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 11, 2020
@hakman hakman force-pushed the ghw-win-2019 branch 4 times, most recently from 1f70b1f to c8cbe9e Compare August 11, 2020 11:14
@hakman
Copy link
Member Author

hakman commented Aug 11, 2020

/cc @rifelpet @mikesplain @johngmyers

@hakman hakman changed the title WIP Add windows job to GH workflows Add windows job to GH workflows Aug 11, 2020
@hakman hakman changed the title WIP Add windows job to GH workflows Add windows job to GH workflows Aug 11, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 11, 2020
@hakman
Copy link
Member Author

hakman commented Aug 11, 2020

/hold for feedback from reviewers

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2020
mikesplain
mikesplain reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@mikesplain mikesplain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from my perspective. Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2020
@hakman
Copy link
Member Author

hakman commented Aug 11, 2020

Thanks @mikesplain.
I renamed some of the commits to reflect the contents better.

@mikesplain
Copy link
Contributor

Oh yeah great thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2020
@rifelpet
Copy link
Member

/lgtm too

@johngmyers
Copy link
Member

/lgtm

@hakman
Copy link
Member Author

hakman commented Aug 11, 2020

Thanks, guys! 😄
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9b46e3f into kubernetes:master Aug 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 11, 2020
@hakman hakman deleted the ghw-win-2019 branch August 15, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain mikesplain left review comments

@johngmyers johngmyers Awaiting requested review from johngmyers

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@mikesplain mikesplain

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@hakman @k8s-ci-robot @mikesplain @rifelpet @johngmyers