Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default kubelet authorization-mode to Webhook for k8s 1.19+ #9718

Merged
merged 1 commit into from
Aug 9, 2020

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Aug 9, 2020

Kubelet defaults the authorization mode to Webhook when the --config flag is provided, but it defaults to the insecure AlwaysAllow mode when the --config flag is not provided.

Since kops uses (the deprecated) flags instead of a config file, this change causes us to get the more secure default.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/nodeup approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2020
@hakman
Copy link
Member

hakman commented Aug 9, 2020

Would be best if you add a short description?
Seems similar to #7200.

@johngmyers
Copy link
Member Author

It might make sense to change the default of AuthenticationTokenWebhook at the same time, but kubelet does not change its default based on whether or not there is a config file.

@johngmyers
Copy link
Member Author

On second thought, AuthenticationTokenWebhook is orthogonal. Instead of disabling insecure features it is enabling additional functionality. A change to its default should be a separate PR.

@hakman
Copy link
Member

hakman commented Aug 9, 2020

Cool. Got it now.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 33c492d into kubernetes:master Aug 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 9, 2020
@johngmyers johngmyers deleted the kubelet-webhook branch August 9, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants