Spotinst: Selecting a default Instance Group in Spot Ocean should be optional #9699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/provider/spotinst
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liranp, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
povils
reviewed
Jan 21, 2021
| } | ||
| } | ||
|
|
||
| klog.V(4).Infof("Detected default launch spec: %q", b.AutoscalingGroupName(ig)) | ||
| } | ||
|
|
||
| // Rename the instance group to avoid duplicate tasks with same name. | ||
| ig.Name = fi.StringValue(ocean.Name) |
There was a problem hiding this comment.
HEy @liranp !
Could it be that this line introduced a bug I might be facing?
By overriding ig.Name it messes up userdata for default nodes:
ocean.UserData, err = b.BootstrapScriptBuilder.ResourceNodeUp(c, ig)
Because now nodeUp tries to fetch instance group config with name "ocean.Name" which ofcourse it doesn;t exist
liranp
added a commit
to spotinst/kubernetes-kops
that referenced
this pull request
Jan 21, 2021
liranp
added a commit
to spotinst/kubernetes-kops
that referenced
this pull request
Jan 21, 2021
liranp
added a commit
to spotinst/kubernetes-kops
that referenced
this pull request
Jan 21, 2021
liranp
added a commit
to spotinst/kubernetes-kops
that referenced
this pull request
Jan 21, 2021
liranp
added a commit
to spotinst/kubernetes-kops
that referenced
this pull request
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the default Instance Group for Spot Ocean is selected to allow users to create new clusters with multiple Instance Groups (#9471) without having to generate their manifests first to select the default by adding the metadata label (
spotinst.io/ocean-default-launchspec).