-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix int to string conversions #9630
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jul 26, 2020
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/provider/aws
Issues or PRs related to aws provider
area/rolling-update
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Jul 26, 2020
hakman
force-pushed
the
fix-char-to-string
branch
from
July 26, 2020 06:10
3b551b1
to
5a9cc3d
Compare
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Jul 26, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 14, 2020
…pstream-release-1.17 Automated cherry pick of #9630: Fix int to string conversions
oded7hoffman
pushed a commit
to spotinst/kubernetes-kops
that referenced
this pull request
Jan 23, 2023
…of-#9630-upstream-release-1.17 Automated cherry pick of kubernetes#9630: Fix int to string conversions
oded7hoffman
pushed a commit
to spotinst/kubernetes-kops
that referenced
this pull request
Jan 23, 2023
…of-#9630-upstream-release-1.17 Automated cherry pick of kubernetes#9630: Fix int to string conversions
oded7hoffman
pushed a commit
to spotinst/kubernetes-kops
that referenced
this pull request
Jan 23, 2023
…of-#9630-upstream-release-1.17 Automated cherry pick of kubernetes#9630: Fix int to string conversions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/provider/aws
Issues or PRs related to aws provider
area/rolling-update
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.15 introduces some new restrictions:
https://tip.golang.org/doc/go1.15#vet