Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix int to string conversions #9630

Merged
merged 1 commit into from
Jul 26, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 26, 2020

Go 1.15 introduces some new restrictions:
https://tip.golang.org/doc/go1.15#vet

# k8s.io/kops/pkg/instancegroups
pkg/instancegroups/rollingupdate_test.go:139:16: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
FAIL	k8s.io/kops/pkg/instancegroups [build failed]

# k8s.io/kops/upup/pkg/fi/cloudup/awsup
upup/pkg/fi/cloudup/awsup/machine_types.go:61:30: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
FAIL	k8s.io/kops/upup/pkg/fi/cloudup/awsup [build failed]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider area/rolling-update approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 26, 2020
@hakman hakman force-pushed the fix-char-to-string branch from 3b551b1 to 5a9cc3d Compare July 26, 2020 06:10
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 75f37d6 into kubernetes:master Jul 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 26, 2020
@hakman hakman deleted the fix-char-to-string branch August 1, 2020 03:29
k8s-ci-robot added a commit that referenced this pull request Aug 14, 2020
…pstream-release-1.17

Automated cherry pick of #9630: Fix int to string conversions
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…of-#9630-upstream-release-1.17

Automated cherry pick of kubernetes#9630: Fix int to string conversions
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…of-#9630-upstream-release-1.17

Automated cherry pick of kubernetes#9630: Fix int to string conversions
oded7hoffman pushed a commit to spotinst/kubernetes-kops that referenced this pull request Jan 23, 2023
…of-#9630-upstream-release-1.17

Automated cherry pick of kubernetes#9630: Fix int to string conversions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants