Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default SELinux security contexts for container runtime binaries #9584

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 17, 2020

With RPMs, SELinux security contexts are magically set for installed files.
In the case of the ones Kops extracts, those security contexts have to be set some other way. Easiest way is to do it during service start.

Note that, at the moment, SELinux support in Kops is limited to worker nodes.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 17, 2020
@hakman
Copy link
Member Author

hakman commented Jul 17, 2020

I believe this is the reason why https://testgrid.k8s.io/sig-storage-kubernetes#kops-selinux is broken at the moment.
/cc @rifelpet @bertinatto

@hakman
Copy link
Member Author

hakman commented Jul 20, 2020

/milestone v1.19

@k8s-ci-robot
Copy link
Contributor

@hakman: You must be a member of the kubernetes/kops-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Kops Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rifelpet rifelpet added this to the v1.19 milestone Jul 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@hakman
Copy link
Member Author

hakman commented Jul 20, 2020

/retest

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit e7414f7 into kubernetes:master Jul 20, 2020
@hakman hakman deleted the fix-selinux branch July 28, 2020 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants