-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM64 support for masters #9566
Conversation
This supports a mixed-arch control plane, which seems unlikely. Perhaps we should have a cluster spec field specifying the arch of the control plane, allowing apply_cluster to save a bunch of asset management. |
9d8decf
to
d80e3b4
Compare
/test pull-kops-e2e-cni-cilium |
@johngmyers I thought about that also, but I decided on not complicating the spec even more. Current implementation allows the node to autodetect whatever OS arch the node has and keeps the logic consistent in the asset management code. I am in four of extending this to a cluster spec option though: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f9209fa
to
1fb4b3d
Compare
/test pull-kops-e2e-cni-cilium |
/hold for feedback from reviewers |
/lgtm This gives me a valid cluster bar the autoscaler pods that comes in #9744 |
/lgtm |
/hold cancel |
/lgtm |
/test all |
/test pull-kops-e2e-cni-kuberouter |
This PR adds build and side-loading support for ARM64 masters:
-amd64
repo suffix.The Protokube check has to be disabled in mock to allow changing the image names change to multi-arch from:
to:
TODO (in future PRs):
-plain
bazel image targets