Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #9543: Remove the checksum workaround for Flannel VXLAN #9549

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 10, 2020

Cherry pick of #9548 on release-1.17.

#9548: Revert "Disable TX checksum offload for Flannel VXLAN"

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jul 10, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2020
@hakman hakman changed the title Automated cherry pick of #9548: Revert "Disable TX checksum offload for Flannel VXLAN" Backport of #9543: Remove the checksum workaround for Flannel VXLAN Jul 10, 2020
@hakman
Copy link
Member Author

hakman commented Jul 10, 2020

/assign @KashifSaadat

@hakman
Copy link
Member Author

hakman commented Jul 10, 2020

/retest

@hakman hakman force-pushed the automated-cherry-pick-of-#9548-upstream-release-1.17 branch from 50f5163 to 52472ad Compare July 10, 2020 05:57
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hakman
To complete the pull request process, please assign kashifsaadat
You can assign the PR to them by writing /assign @kashifsaadat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 10, 2020

@hakman: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kops-verify-generated 52472ad link /test pull-kops-verify-generated
pull-kops-verify-hashes 52472ad link /test pull-kops-verify-hashes

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hakman
Copy link
Member Author

hakman commented Jul 10, 2020

The failed tests will be removed in kubernetes/test-infra#18254.

@hakman
Copy link
Member Author

hakman commented Jul 10, 2020

/retest

@hakman
Copy link
Member Author

hakman commented Jul 11, 2020

The failed tests should not exist for this branch. Probably a new PR will be required to not trigger them.

@hakman hakman closed this Jul 11, 2020
@hakman hakman deleted the automated-cherry-pick-of-#9548-upstream-release-1.17 branch July 11, 2020 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants