Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default ClusterDNS appropriately when NodeLocalDNS is enabled #9491

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Default ClusterDNS appropriately when NodeLocalDNS is enabled #9491

merged 1 commit into from
Jul 6, 2020

Conversation

johngmyers
Copy link
Member

@k8s-ci-robot k8s-ci-robot requested a review from olemarkus July 3, 2020 23:49
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/api area/documentation labels Jul 3, 2020
@olemarkus
Copy link
Member

Thanks for this. I think this does make things simpler for users.
If this goes in, we'd want this backported to 1.18 too.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2020
@johngmyers
Copy link
Member Author

One question is whether ClusterDNS should default to NodeLocalDNS.LocalIP for all cases when NodeLocalDNS is enabled, not just the ones where it doesn't work otherwise.

@olemarkus
Copy link
Member

An earlier PR I had of this did that. I suspect there may be other cases where you need localIP. For example calico in BPF (kubeproxy-free) mode.

@johngmyers
Copy link
Member Author

/assign @rifelpet
It would be good to get this into 1.18 branch soon.

@rifelpet
Copy link
Member

rifelpet commented Jul 6, 2020

👍
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2020
@johngmyers johngmyers mentioned this pull request Jul 6, 2020
Merged
@k8s-ci-robot k8s-ci-robot merged commit a97fc42 into kubernetes:master Jul 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 6, 2020
@johngmyers johngmyers deleted the nodeport-dns branch July 6, 2020 05:30
k8s-ci-robot added a commit that referenced this pull request Jul 6, 2020
@k8s-ci-robot
Merge pull request #9505 from johngmyers/automated-cherry-pick-of-#94…
1b7eb3c 
…91-release-1.18

Automated cherry pick of #9491: Default ClusterDNS appropriately when NodeLocalDNS is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@olemarkus olemarkus

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@johngmyers @olemarkus @rifelpet @k8s-ci-robot