Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable disk based evictions for Kubernetes 1.19 #9475

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 2, 2020

Issues with cAdvisor were fixed and merged into Kubernetes 1.19.
The fix should be available in 1.19.0-rc.1 next week. Until then, the e2e test will fail.

xRef: google/cadvisor#2586
Reverts: #9296
Fixes: #9301

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2020
@olemarkus
Copy link
Member

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@hakman
Copy link
Member Author

hakman commented Jul 2, 2020

@olemarkus The fix should be available in 1.19.0-rc.1 next week. Until then, the e2e test will fail.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2020
@hakman hakman force-pushed the disk-based-evictions branch from a53ee9d to 4eb6028 Compare July 9, 2020 16:27
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 9, 2020
@hakman hakman force-pushed the disk-based-evictions branch from 4eb6028 to 06df2cc Compare July 9, 2020 16:36
@hakman
Copy link
Member Author

hakman commented Jul 10, 2020

/retest

@rifelpet
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2020
@hakman
Copy link
Member Author

hakman commented Jul 10, 2020

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit 13491ab into kubernetes:master Jul 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Periodic e2e fails for Kubernetes 1.19 - cAdvisor incorrectly detects ImageFS free space
4 participants