Use -mod=vendor for most go commands #9396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this set, go 1.13 was redownloading all dependencies into the module cache, effectively ignoring the vendor directory. This instructs go 1.13 to always use (and verify the contents of) the vendor directory. See an example prow job here: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kops/9389/pull-kops-verify-govet/1273460433402990595 All of the `go: downloading` and `go: extracting` lines indicate its downloading those dependencies rather than using the vendor directory.
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/test all |
k8s-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/unassign @justinsb while i work out some issues |
|
/test all |
rifelpet
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
though it would probably be best to vendor this?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this set, go 1.13 was redownloading all dependencies into the module cache, effectively ignoring the vendor directory.
This instructs go 1.13 to always use (and verify the contents of) the vendor directory.
See an example prow job here. All of the
go: downloadingandgo: extractinglines indicate its downloading those dependencies rather than using the vendor directory.Unsetting it for when we actually update the vendor directory with
make gomod.I'm not sure if/how this affects bazel
Ref: #9389 (comment)
/assign @justinsb