Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start moving InstanceGroup data to NodeupConfig #9391

Merged
merged 4 commits into from
Jun 18, 2020

Conversation

johngmyers
Copy link
Member

This is the first few commits of #9294 submitted separately in attempt to make it more reviewable. It stops short of the first commit that has userdata size limit concerns.

This lays down some groudwork I'll need for other refactoring efforts.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/api labels Jun 18, 2020
@justinsb
Copy link
Member

Thanks - great idea to break it into smaller steps.

I also had an idea - we could have a "compatability" mode where we have a field FileAssets: true or Hooks: true. In that case we would continue to load the instance group from the yaml file (it would have non-ideal semantics, but it wouldn't be a regression). We could even do something like allow for (say) 8KB of data inline, but if we go over then we log a warning and only in that case would we set the flag e.g. LoadExternalAssets: true

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@johngmyers
Copy link
Member Author

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit e8f8eb0 into kubernetes:master Jun 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 18, 2020
@johngmyers johngmyers deleted the refactor-nodeup-start branch June 18, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants