-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #8965: Fix missing changes in Weave manifest #9285: Update Weave for CVE-2020-13597 #9329
Conversation
90e1ff3
to
e3677d3
Compare
e3677d3
to
f3ca5b7
Compare
labels: | ||
name: weave-net | ||
role.kubernetes.io/networking: "1" | ||
namespace: kube-system | ||
spec: | ||
# Wait 5 seconds to let pod connect before rolling next pod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that comment also be moved with the field itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I will add a note to do it with the next release. I don't think it's ok to do it in this cherry-pick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, I didn't notice that it's a CP, sorry!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np. good catch.
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…of-#8965-kubernetes#9285-upstream-release-1.16 Automated cherry pick of kubernetes#8965: Fix missing changes in Weave manifest kubernetes#9285: Update Weave for CVE-2020-13597
…of-#8965-kubernetes#9285-upstream-release-1.16 Automated cherry pick of kubernetes#8965: Fix missing changes in Weave manifest kubernetes#9285: Update Weave for CVE-2020-13597
…of-#8965-kubernetes#9285-upstream-release-1.16 Automated cherry pick of kubernetes#8965: Fix missing changes in Weave manifest kubernetes#9285: Update Weave for CVE-2020-13597
Cherry pick of #8965 #9285 on release-1.16.
#8965: Fix missing changes in Weave manifest
#9285: Update Weave for CVE-2020-13597
For details on the cherry pick process, see the cherry pick requests page.