Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mkdocs to latest versions #9309

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

rifelpet
Copy link
Member

@rifelpet rifelpet commented Jun 9, 2020

The biggest improvement I see is much snappier search results.

followed the material theme upgrade instructions here

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mikesplain and zetaab June 9, 2020 03:45
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2020
@rifelpet rifelpet force-pushed the docs-upgrade branch 4 times, most recently from 98c5b0c to d4b93a1 Compare June 9, 2020 04:02
@rifelpet
Copy link
Member Author

rifelpet commented Jun 9, 2020

this may need to wait until netlify updates the image tag used in their builds: https://github.com/netlify/build-image/releases/tag/v3.3.15 in order to support PYTHON_VERSION env var (its defaulting to 2.7 which doesn't have the newest modules we're upgrading to)

build log shows:

11:02:56 PM: build-image tag: v3.3.14

They push tags every couple weeks and the newest tag with PYTHON_VERSION support is only 6 days old, so hopefully it won't be long before builds start using it. alternatively we create a runtime.txt in the repo root but that's not very clean. I'd rather wait for the env var support.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2020
@mikesplain
Copy link
Contributor

Looks good, only holding an lgtm since we can’t see a preview, hopefully they’ll get that updated soon!

Thanks!

@rifelpet
Copy link
Member Author

netlify updated their build environment to 3.3.15:

https://app.netlify.com/sites/kubernetes-kops/deploys/5ee9819edcd1790007bb6543

which supports specifying the python version by env var, as you can see it is now using python 3.7. The rest of the build succeeds and you can check out the deploy preview as normal.

I think this is ready for review/merge

RUN apk update && apk add --no-cache \
RUN apk add --no-cache \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the apk update part?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add's --no-cache performs an update under the hood but doesnt cache the results. you can see the indexes being downloaded twice:

docker run -it --rm alpine
/ # apk update && apk add --no-cache bash
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/community/x86_64/APKINDEX.tar.gz
v3.12.0-74-gb8f92cf12a [http://dl-cdn.alpinelinux.org/alpine/v3.12/main]
v3.12.0-76-ge6ea27f814 [http://dl-cdn.alpinelinux.org/alpine/v3.12/community]
OK: 12734 distinct packages available
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/community/x86_64/APKINDEX.tar.gz
(1/4) Installing ncurses-terminfo-base (6.2_p20200523-r0)
(2/4) Installing ncurses-libs (6.2_p20200523-r0)
(3/4) Installing readline (8.0.4-r0)
(4/4) Installing bash (5.0.17-r0)
Executing bash-5.0.17-r0.post-install
Executing busybox-1.31.1-r16.trigger
OK: 8 MiB in 18 packages

also see SO

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Nice trick.

@rifelpet
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@hakman
Copy link
Member

hakman commented Jun 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit b02c3c3 into kubernetes:master Jun 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 17, 2020
@rifelpet rifelpet deleted the docs-upgrade branch October 29, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants