-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mkdocs to latest versions #9309
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
98c5b0c
to
d4b93a1
Compare
this may need to wait until netlify updates the image tag used in their builds: https://github.com/netlify/build-image/releases/tag/v3.3.15 in order to support PYTHON_VERSION env var (its defaulting to 2.7 which doesn't have the newest modules we're upgrading to) build log shows:
They push tags every couple weeks and the newest tag with PYTHON_VERSION support is only 6 days old, so hopefully it won't be long before builds start using it. alternatively we create a runtime.txt in the repo root but that's not very clean. I'd rather wait for the env var support. /hold |
Looks good, only holding an lgtm since we can’t see a preview, hopefully they’ll get that updated soon! Thanks! |
netlify updated their build environment to 3.3.15: https://app.netlify.com/sites/kubernetes-kops/deploys/5ee9819edcd1790007bb6543 which supports specifying the python version by env var, as you can see it is now using python 3.7. The rest of the build succeeds and you can check out the deploy preview as normal. I think this is ready for review/merge |
RUN apk update && apk add --no-cache \ | ||
RUN apk add --no-cache \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the apk update
part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add
's --no-cache
performs an update
under the hood but doesnt cache the results. you can see the indexes being downloaded twice:
docker run -it --rm alpine
/ # apk update && apk add --no-cache bash
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/community/x86_64/APKINDEX.tar.gz
v3.12.0-74-gb8f92cf12a [http://dl-cdn.alpinelinux.org/alpine/v3.12/main]
v3.12.0-76-ge6ea27f814 [http://dl-cdn.alpinelinux.org/alpine/v3.12/community]
OK: 12734 distinct packages available
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.12/community/x86_64/APKINDEX.tar.gz
(1/4) Installing ncurses-terminfo-base (6.2_p20200523-r0)
(2/4) Installing ncurses-libs (6.2_p20200523-r0)
(3/4) Installing readline (8.0.4-r0)
(4/4) Installing bash (5.0.17-r0)
Executing bash-5.0.17-r0.post-install
Executing busybox-1.31.1-r16.trigger
OK: 8 MiB in 18 packages
also see SO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Nice trick.
/hold cancel |
/lgtm |
The biggest improvement I see is much snappier search results.
followed the material theme upgrade instructions here