Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment on blocking jobs to actions #9305

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

mikesplain
Copy link
Contributor

To document the changes in kubernetes/test-infra#17857.

/cc @rifelpet

Holding until that PR merges and make sure it works.
/hold

@k8s-ci-robot k8s-ci-robot requested a review from rifelpet June 8, 2020 19:19
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 8, 2020
@rifelpet
Copy link
Member

rifelpet commented Jun 8, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2020
@mikesplain
Copy link
Contributor Author

mikesplain commented Jun 8, 2020

@mikesplain
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 17, 2020
@rifelpet
Copy link
Member

rifelpet commented Jun 17, 2020

not sure why tide isn't picking this up...

Pending - Not mergeable

yet the tide link says it's ready to merge. I wonder if this is an issue with kubernetes/test-infra#17917 ?

@mikesplain
Copy link
Contributor Author

/retest

I’m not sure either. Status reconciler should update and retest if need be. I’ll look tomorrow and worst case we can revert.

@mikesplain mikesplain closed this Jun 17, 2020
@mikesplain mikesplain reopened this Jun 17, 2020
@mikesplain
Copy link
Contributor Author

Close and reopening to re-trigger tests

@hakman
Copy link
Member

hakman commented Jun 17, 2020

Same thing here #9233.

@hakman
Copy link
Member

hakman commented Jun 17, 2020

@mikesplain I prepared the revert with approval. I just requires the LGTM.

@k8s-ci-robot k8s-ci-robot merged commit 872e95f into kubernetes:master Jun 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants