-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment on blocking jobs to actions #9305
Add comment on blocking jobs to actions #9305
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold cancel |
not sure why tide isn't picking this up...
yet the tide link says it's ready to merge. I wonder if this is an issue with kubernetes/test-infra#17917 ? |
/retest I’m not sure either. Status reconciler should update and retest if need be. I’ll look tomorrow and worst case we can revert. |
Close and reopening to re-trigger tests |
Same thing here #9233. |
@mikesplain I prepared the revert with approval. I just requires the LGTM. |
To document the changes in kubernetes/test-infra#17857.
/cc @rifelpet
Holding until that PR merges and make sure it works.
/hold