Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove romana support #9255

Merged
merged 5 commits into from
Jun 3, 2020
Merged

Remove romana support #9255

merged 5 commits into from
Jun 3, 2020

Conversation

olemarkus
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 3, 2020
@k8s-ci-robot k8s-ci-robot requested review from drekle and mikesplain June 3, 2020 06:37
@hakman
Copy link
Member

hakman commented Jun 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2020
johngmyers
johngmyers reviewed Jun 3, 2020
View reviewed changes
docs/releases/1.19-NOTES.md Outdated Show resolved Hide resolved
pkg/apis/kops/validation/validation.go Outdated
@@ -367,6 +367,7 @@ func validateNetworking(c *kops.ClusterSpec, v *kops.NetworkingSpec, fldPath *fi
}

if v.Romana != nil {
allErrs = append(allErrs, field.Forbidden(fldPath.Child("romana"), "support for Romana has been removed"))
if optionTaken {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if block can be removed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it? If I remove that block, kops creates my cluster.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A validation error should prevent creation. How is that happening?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I thought you were referring to the outer if. Yeah, this one can technically be removed.

@olemarkus @johngmyers
Update docs/releases/1.19-NOTES.md
e6f69f6 
Co-authored-by: John Gardiner Myers <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2020
@rifelpet
Copy link
Member

rifelpet commented Jun 3, 2020

this looks good to me too. i'm curious if/when we'd want to remove the RomanaNetworkingSpec type from the API altogether. If we remove it now, kops will error saying the field isnt recognized. I suppose having an explicit validation error is clearer to the user, but it might be a good idea to come up with a plan to remove the type altogether.

@olemarkus
Copy link
Member Author

We can remove the struct from the next API version, but I think we should keep the unversioned struct for as long as any versioned API has the struct so that people run into the validation errors.

@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2020
@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Jun 3, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus, rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4fe5ad0 into kubernetes:master Jun 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jun 3, 2020
@rifelpet rifelpet removed this from the v1.18 milestone Jun 4, 2020
@rifelpet rifelpet added this to the v1.19 milestone Jun 4, 2020
@justinsb
Copy link
Member

Agree with keeping the API fields, to explicitly mark it deprecated and help users. Also makes it easier if we change our mind and re-add support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers left review comments

@drekle drekle Awaiting requested review from drekle

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@rdrgmnzs rdrgmnzs

@johngmyers johngmyers

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/nodeup area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
7 participants
@olemarkus @hakman @rifelpet @johngmyers @rdrgmnzs @k8s-ci-robot @justinsb