Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #8237: Initial changes for load balancer task #9168

Merged
merged 6 commits into from
May 25, 2020
Merged

Automated cherry pick of #8237: Initial changes for load balancer task #9168

merged 6 commits into from
May 25, 2020

Conversation

srikiz
Copy link
Contributor

@srikiz srikiz commented May 23, 2020

Cherry pick of #8237 on release-1.17.

#8237: Initial changes for load balancer task

For details on the cherry pick process, see the cherry pick requests page.

srikiz added 6 commits May 23, 2020 18:44
@srikiz
Initial changes for load balancer task
1f89092 
Add load balancer fi tasks

Add load balancer builder for DO

Fix go imports

Implement FindIPAddress functionality

Add load balancer api ingress status calls

Add error checks for FindIPAddress

Add delete LB option

Update load balancer delete logic

Revert make file changes

revert utils code changes

Revert NewDOCloud changes

Remove minor code comments

Update with gomod for dependencies
@srikiz
Fix few review comments
d978203
@srikiz
Update more review comments
147a3be
@srikiz
Address all review comments
3f08adb
@srikiz
Incorporate review comments
d9cf105
@srikiz
Incorporate further review comments
0deefdc
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone May 23, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @srikiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2020
@granular-ryanbonham
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2020
@rifelpet
Copy link
Member

/approve

@rifelpet
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, srikiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4d8c8ba into kubernetes:release-1.17 May 25, 2020
@srikiz srikiz deleted the automated-cherry-pick-of-#8237-upstream-release-1.17 branch May 26, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@granular-ryanbonham granular-ryanbonham Awaiting requested review from granular-ryanbonham

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
4 participants
@srikiz @k8s-ci-robot @granular-ryanbonham @rifelpet