kube-apiserver-healthcheck: actually enable on 1.17 #9095
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
|
I expect this to fail until we merge #9096 |
We cherry picked, but now we need to activate the feature.
justinsb
force-pushed
the
enable_healthcheck_1_17
branch
from
f612af2 to
11b0b30
Compare
| @@ -296,7 +296,7 @@ func (b *KubeAPIServerOptionsBuilder) BuildOptions(o interface{}) error { | |||
| c.AnonymousAuth = fi.Bool(false) | |||
| } | |||
|
|
|||
| if b.IsKubernetesGTE("1.18") { | |||
| if b.IsKubernetesGTE("1.17") { | |||
There was a problem hiding this comment.
You'll want to change this on master branch as well. How about first landing to master and then cherrypicking?
There was a problem hiding this comment.
Fair point, that's an easy follow up.
There was a problem hiding this comment.
Oops - will send PR to master now :-)
There was a problem hiding this comment.
Thanks @justinsb, I definitely support getting this in.
/lgtm
/approve
| @@ -296,7 +296,7 @@ func (b *KubeAPIServerOptionsBuilder) BuildOptions(o interface{}) error { | |||
| c.AnonymousAuth = fi.Bool(false) | |||
| } | |||
|
|
|||
| if b.IsKubernetesGTE("1.18") { | |||
| if b.IsKubernetesGTE("1.17") { | |||
There was a problem hiding this comment.
Fair point, that's an easy follow up.
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We cherry picked, but now we need to activate the feature.