Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #9074: Disable TX checksum offload for Flannel VXLAN #9078

Merged
merged 1 commit into from
May 7, 2020
Merged

Automated cherry pick of #9074: Disable TX checksum offload for Flannel VXLAN #9078

merged 1 commit into from
May 7, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented May 6, 2020

Cherry pick of #9074 on release-1.17.

#9074: Disable TX checksum offload for Flannel VXLAN

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone May 6, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 6, 2020
@k8s-ci-robot k8s-ci-robot requested review from chrisz100 and rifelpet May 6, 2020 16:48
@hakman
Copy link
Member Author

hakman commented May 6, 2020

/hold to wait for some periodic e2e passes

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2020
@hakman
Copy link
Member Author

hakman commented May 7, 2020

Tests run without issues. NodeUp waits for Flannel to start and the service applies the fix:
https://storage.googleapis.com/kubernetes-jenkins/logs/e2e-kops-aws-cni-flannel/1258184354379599874/artifacts/ip-172-20-57-246.eu-central-1.compute.internal/kops-configuration.log

@hakman
Copy link
Member Author

hakman commented May 7, 2020

/assign @rifelpet
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2020
@johngmyers
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2020
@rifelpet
Copy link
Member

rifelpet commented May 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit ffacedf into kubernetes:release-1.17 May 7, 2020
@hakman hakman deleted the automated-cherry-pick-of-#9074-upstream-release-1.17 branch July 1, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisz100 chrisz100 Awaiting requested review from chrisz100

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@rifelpet rifelpet

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @johngmyers @rifelpet @k8s-ci-robot