Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openstack): propagate cloud labels to machines #8999

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

mitch000001
Copy link
Contributor

This PR enables propagation of cloud labels onto the instances.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mitch000001. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 27, 2020
@k8s-ci-robot k8s-ci-robot requested review from drekle and zetaab April 27, 2020 13:42
@k8s-ci-robot k8s-ci-robot added the area/provider/openstack Issues or PRs related to openstack provider label Apr 27, 2020
@mitch000001 mitch000001 force-pushed the openstack-cloud-labels branch from 4160f21 to fc5807d Compare April 27, 2020 13:58
@hakman
Copy link
Member

hakman commented Apr 27, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2020
Copy link
Member

@zetaab zetaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mitch000001, zetaab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit ec2e52c into kubernetes:master Apr 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Apr 27, 2020
@mitch000001
Copy link
Contributor Author

Awesome, thx for the fast responses :D

@mitch000001 mitch000001 deleted the openstack-cloud-labels branch April 27, 2020 15:03
k8s-ci-robot added a commit that referenced this pull request Apr 27, 2020
…999-origin-release-1.17

Automated cherry pick of #8999: feat(openstack): propagate cloud labels to machines
k8s-ci-robot added a commit that referenced this pull request Apr 30, 2020
…999-origin-release-1.16

Automated cherry pick of #8999: feat(openstack): propagate cloud labels to machines
zetaab added a commit to zetaab/kops that referenced this pull request May 7, 2020
zetaab added a commit to zetaab/kops that referenced this pull request May 7, 2020
k8s-ci-robot added a commit that referenced this pull request May 7, 2020
…k-of-#8999-origin-release-1.16

Revert "Automated cherry pick of #8999: feat(openstack): propagate cloud labels to machines"
k8s-ci-robot added a commit that referenced this pull request May 7, 2020
…k-of-#8999-origin-release-1.17

Revert "Automated cherry pick of #8999: feat(openstack): propagate cloud labels to machines"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants