-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for the legacy etcd provider as of k8s 1.18 #8826
Remove support for the legacy etcd provider as of k8s 1.18 #8826
Conversation
I am all for getting rid of the legacy etcd provider, but isn't it better to do this based on kops version instead of k8s version? There is nothing in k8s that requires dropping legacy etcd, and as a user, it is always confusing when the k8s version is what determines what kops functionality is supported. I would rather go for a deprecation in kops 1.17 and removal in kops 1.19 or something. that will also let us get rid of the code. If we base it on k8s version, we'll be still stuck with the code "forever". |
This is in line with the pattern of not making substantial changes in behavior to existing clusters until those clusters upgrade Kubernetes. Eventually kops will drop support for Kubernetes 1.17 and the legacy manager code will then be removed. |
eb86039
to
9311c64
Compare
Conflicts with #8614 and want that PR to go in first because it is going to be cherrypicked. |
9311c64
to
359d834
Compare
/hold cancel |
359d834
to
3f66e09
Compare
/retest |
I see /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest quay... |
quay says they fixed it :) |
This proposes to remove support for the legacy etcd provider for clusters running Kubernetes 1.18 or later.