-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ubuntu 20.04 (Focal) #8727
Conversation
/cc @rifelpet |
if b.Distribution == distros.DistributionBionic && c.ResolverConfig == nil { | ||
c.ResolverConfig = s("/run/systemd/resolve/resolv.conf") | ||
if c.ResolverConfig == nil { | ||
if b.Distribution == distros.DistributionBionic || b.Distribution == distros.DistributionFocal { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of interest, do you know that this was needed? I was hoping they might have fixed it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a more general issue for distros that enable DNS cache via systemd-resolved
, so not sure it can be fixed. Without this CoreDNS keeps complaining about a DNS loop:
https://github.com/coredns/coredns/blob/master/plugin/loop/README.md#troubleshooting-loops-in-kubernetes-clusters
Thanks @hakman /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…pstream-release-1.17 Automated cherry pick of #8727: Add support for Ubuntu 20.04 (Focal)
…pstream-release-1.16 Automated cherry pick of #8727: Add support for Ubuntu 20.04 (Focal)
Ubuntu 20.04 is close to release and will be the next Ubuntu LTS release.
From Kubernetes point of view, this will be the supported distro with the newest Kernel for some time (Debian 10 and RHEL/CentOS 8 were just released).
Once official stable images are released will add an e2e test for it.