Enhancement in Ubuntu or debian apt-get and CI issue fix #8687
Conversation
|
Hi @Rajpratik71. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
@hakman @rifelpet @mikesplain requesting review , new PR as per changes asked in #8681 |
|
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
cncf-cla: yes
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
@robinpercy @joshbranham requesting review |
|
The commit messages have a lot of repeated text. Please remove the duplicate text. |
Rajpratik71
force-pushed
the
enhancement/apt
branch
from
af2ea7c to
5ba8d17
Compare
done as requested |
|
@johngmyers please review , done as requested |
|
/cc @hakman |
k8s-ci-robot
added
needs-rebase
|
@robinpercy requesting review |
|
@Rajpratik71 you will need to rebase on top of master. We no longer allow merge commits in PRs. |
Rajpratik71
force-pushed
the
enhancement/apt
branch
from
bd884e8 to
68f63d2
Compare
done as requested |
|
It looks like this makes a test data file executable. Please remove that change. |
Rajpratik71
force-pushed
the
enhancement/apt
branch
from
68f63d2 to
e544b87
Compare
fixed |
k8s-ci-robot
added
the
needs-rebase
Rajpratik71
force-pushed
the
enhancement/apt
branch
from
e544b87 to
7219916
Compare
k8s-ci-robot
added
size/XS
Rajpratik71
force-pushed
the
enhancement/apt
branch
from
7219916 to
1a523af
Compare
|
@Rajpratik71: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@Rajpratik71 this PR needs to be rebased for the tests to work. |
By default, Ubuntu or Debian based "apt" or "apt-get" system installs recommended but not suggested packages . By passing "--no-install-recommends" option, the user lets apt-get know not to consider recommended packages as a dependency to install. This results in smaller downloads and installation of packages . Refer to blog at [Ubuntu Blog](https://ubuntu.com/blog/we-reduced-our-docker-images-by-60-with-no-install-recommends) . Signed-off-by: Pratik Raj <[email protected]>
Rajpratik71
force-pushed
the
enhancement/apt
branch
from
1a523af to
e9bafc6
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, Rajpratik71 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This PR is clean version of #8681 as requested
Major Changes No 1 : debian package manager tweaks
By default, Ubuntu or Debian based "apt" or "apt-get" system installs recommended but not suggested packages .
By passing "--no-install-recommends" option, the user lets apt-get know not to consider recommended packages as a dependency to install.
This results in smaller downloads and installation of packages .
Refer to blog at Ubuntu Blog .
Major Changes No 2 : added packages apt-utils ca-certificates
Because Github CI build is
Slow and in log it is showing because "apt-utils" not installed
to avoid CI build to exits with error without having certificate