-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add s3 region #8592
add s3 region #8592
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How are you passing custom credentials to etcd-manager? Just curious |
I am defining following before running kops commands like kops create cluster:
These environment variable are then passed to etcd manager container (or before this PR all other than S3_REGION) was passed. I have tested this PR and now everything works. Use-case for this solution is that we have shared one s3 bucket to many clusters. Of course each cluster do have own iam account (and bucket policy) that those are isolated. We are doing this because some of our clusters are in OpenStack, GCE and AWS. Common place for all stores makes it much easier to manage |
/lgtm |
cherrypick #8592 (add s3 region)
cherrypick #8592 (add s3 region)
we are currently seeing following error in etcd-manager:
this is because we are using custom s3 credentials and s3 region is not passed to etcd-manager container (so it defaults to us-east-1)