Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag EBS volumes when using launch templates with AWS API target #8462

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Tag EBS volumes when using launch templates with AWS API target #8462

merged 1 commit into from
Feb 3, 2020

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 2, 2020
@johngmyers
Copy link
Member Author

/retest

@rifelpet
Copy link
Member

rifelpet commented Feb 3, 2020

we can add terraform and cloudformation support in a separate PR

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0c7cbee into kubernetes:master Feb 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 3, 2020
@johngmyers johngmyers deleted the tag-volume branch February 3, 2020 05:15
@hakman hakman mentioned this pull request Feb 3, 2020
Merged
@rifelpet rifelpet mentioned this pull request Mar 3, 2020
Closed
@hakman hakman mentioned this pull request Mar 8, 2020
Merged
This was referenced Mar 27, 2020
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Mar 27, 2020
@k8s-ci-robot
Merge pull request #8806 from hakman/automated-cherry-pick-of-#8462-#…
51e1e6b 
…8466-upstream-release-1.16

Automated cherry pick of #8462: Tag EBS volumes when using launch templates with AWS API #8466: Update tags support for LaunchTemplates
k8s-ci-robot added a commit that referenced this pull request Mar 27, 2020
@k8s-ci-robot
Merge pull request #8805 from hakman/automated-cherry-pick-of-#8462-#…
336e22c 
…8466-upstream-release-1.17

Automated cherry pick of #8462: Tag EBS volumes when using launch templates with AWS API #8466: Update tags support for LaunchTemplates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@robinpercy robinpercy Awaiting requested review from robinpercy

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
3 participants
@johngmyers @rifelpet @k8s-ci-robot