-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cilium.EnablePolicy back into templates #8379
Conversation
Hi @olemarkus. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test pull-kops-e2e-kubernetes-aws |
1 similar comment
/test pull-kops-e2e-kubernetes-aws |
/retest |
3 similar comments
/retest |
/retest |
/retest |
As far as I can tell, the build skips uploading any artifacts like protokube etc. Which perhaps makes sense since I don't change any of them. |
This may have dropped out when we bumped Cilium to 1.6 It is possible to set this value in the cluster spec, but it isn't used anywhere
a87d697
to
5a5508a
Compare
A rebase fixed it, it seems 🤷♂️ |
/kind bug |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…79-upstream-release-1.17 Automated cherry pick of #8379: Add Cilium.EnablePolicy back into templates
…79-upstream-release-1.16 Automated cherry pick of #8379: Add Cilium.EnablePolicy back into templates
This may have dropped out when we bumped Cilium to 1.6
It is possible to set this value in the cluster spec, but it isn't used anywhere