Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some ancient release notes and migration docs #8372

Closed
wants to merge 1 commit into from

Conversation

johngmyers
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 18, 2020
@johngmyers
Copy link
Member Author

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johngmyers
To complete the pull request process, please assign granular-ryanbonham
You can assign the PR to them by writing /assign @granular-ryanbonham in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johngmyers
Copy link
Member Author

/retest

@mikesplain
Copy link
Contributor

I personally think we shouldn't be removing those release notes. K/K doesn't so why should we? I'm fine with removing some of the other files but I think the history is important here. Most open source projects keep their release notes in some form in perpetuity, I'm not sure why we should be any different.

@johngmyers
Copy link
Member Author

The Calico CIDR migration docs are linked to by the 1.7 release notes, so we either maintain them (including the script that fails shellcheck), we have a dead link, or we remove the old release notes.

People can research ancient history by going back in the git logs. I don't think we should spend effort maintaining these ancient, obsolete documents.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2020
@olemarkus
Copy link
Member

I vote for removing old migration docs. K8s docs are versioned so it is not comparable to our docs. Should we start using versioned docs as well in the future, those old migration docs and scripts will resurface.

Related: #9107

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2020
@hakman
Copy link
Member

hakman commented May 26, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 26, 2020
@johngmyers
Copy link
Member Author

/assign @granular-ryanbonham

@hakman
Copy link
Member

hakman commented Jun 22, 2020

/assign @rifelpet

@rifelpet
Copy link
Member

I'm a bit torn on this. On one side, k/k keeps all changelogs in their master branch. On the other side, many open source projects truncate their changelogs, either to the most recent major version or something like what this PR is doing, and the changelogs still exist in git history.

What exactly do we gain by deleting them? not spend time fixing broken links? Anything else?

@johngmyers
Copy link
Member Author

We wouldn't have to maintain obsolete docs, such as those for the Calico CIDR migration, that are referenced by obsolete release notes.

Also, these early release notes aren't named consistently.

@k8s-ci-robot
Copy link
Contributor

@johngmyers: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kops-e2e-k8s-containerd bd9c011 link /test pull-kops-e2e-k8s-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2020
@k8s-ci-robot
Copy link
Contributor

@johngmyers: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman
Copy link
Member

hakman commented Aug 19, 2020

@johngmyers Now that #9770 was merged, should this be closed?

@johngmyers
Copy link
Member Author

Closing

@johngmyers johngmyers closed this Aug 19, 2020
@johngmyers johngmyers deleted the remove-docs branch April 22, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants