-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove some ancient release notes and migration docs #8372
Conversation
/area documentation |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
63c9d11
to
bd9c011
Compare
I personally think we shouldn't be removing those release notes. K/K doesn't so why should we? I'm fine with removing some of the other files but I think the history is important here. Most open source projects keep their release notes in some form in perpetuity, I'm not sure why we should be any different. |
The Calico CIDR migration docs are linked to by the 1.7 release notes, so we either maintain them (including the script that fails shellcheck), we have a dead link, or we remove the old release notes. People can research ancient history by going back in the git logs. I don't think we should spend effort maintaining these ancient, obsolete documents. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
I vote for removing old migration docs. K8s docs are versioned so it is not comparable to our docs. Should we start using versioned docs as well in the future, those old migration docs and scripts will resurface. Related: #9107 /lgtm |
/remove-lifecycle stale |
/assign @granular-ryanbonham |
/assign @rifelpet |
I'm a bit torn on this. On one side, k/k keeps all changelogs in their master branch. On the other side, many open source projects truncate their changelogs, either to the most recent major version or something like what this PR is doing, and the changelogs still exist in git history. What exactly do we gain by deleting them? not spend time fixing broken links? Anything else? |
We wouldn't have to maintain obsolete docs, such as those for the Calico CIDR migration, that are referenced by obsolete release notes. Also, these early release notes aren't named consistently. |
@johngmyers: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@johngmyers: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@johngmyers Now that #9770 was merged, should this be closed? |
Closing |
No description provided.