-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for weave.npcExtraArgs #8265
Add support for weave.npcExtraArgs #8265
Conversation
Hi @ReillyProcentive. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @mikesplain |
/ok-to-test |
For the manifest's hash, you need to update them when you change the templates. Run /hack/update-expected.sh to update the hashes. |
It'd be great if you could add this and netExtraArgs to this test. Then run |
upup/models/cloudup/resources/addons/networking.weave/k8s-1.7.yaml.template
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and corresponding comment fixes to v1alpha1 and v1alpha2
…upport for K8S 1.7
looks good, and the consistency with |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReillyProcentive, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes #7390
References weaveworks/weave#3683
This change is excluded from k8s-1.6.yaml.template as this environmental variable is only effective on Weave 2.6.0 and above.